Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(instrumentation): ensure .setConfig() results in config.enabled defaulting to true #4941

Merged
merged 2 commits into from
Aug 22, 2024
Merged

fix(instrumentation): ensure .setConfig() results in config.enabled defaulting to true #4941

merged 2 commits into from
Aug 22, 2024

Commits on Aug 21, 2024

  1. fix(instrumentation): ensure .setConfig() results in config.enabled d… 

    …efaulting to true

Before this change an instrumentation instance's config, as returned
from .getConfig(), would include {enabled: true} after construction,
`new MyInstrumentation()`; but would not include 'enabled' after
`.setConfig({})`. That inconsistency could cause bugs in usage of
`this.getConfig().enabled`.
    @trentm
    trentm committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    7b3fa58 View commit details
    Browse the repository at this point in the history

  2. changelog entry

    @trentm
    trentm committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    ff56638 View commit details
    Browse the repository at this point in the history