Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(opentelemetry-core): confusing log extract of composite propagator #5017

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

rv2673
Copy link
Contributor

@rv2673 rv2673 commented Sep 25, 2024

Which problem is this PR solving?

This fixes confusing diag logged warning in the composite propagator.

Short description of the changes

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

The existing test were used for checking for regression.

Checklist:

  • Followed the style guidelines of this project
    - [ ] Unit tests have been added
    - [ ] Documentation has been updated

Copy link

linux-foundation-easycla bot commented Sep 25, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@rv2673 rv2673 marked this pull request as ready for review September 25, 2024 19:19
@rv2673 rv2673 requested a review from a team as a code owner September 25, 2024 19:19
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing this 👍

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.92%. Comparing base (f8ab559) to head (c1e33ad).
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5017      +/-   ##
==========================================
+ Coverage   93.39%   93.92%   +0.53%     
==========================================
  Files          46      310     +264     
  Lines         712     8138    +7426     
  Branches      120     1633    +1513     
==========================================
+ Hits          665     7644    +6979     
- Misses         47      494     +447     
Files with missing lines Coverage Δ
...es/opentelemetry-core/src/propagation/composite.ts 100.00% <ø> (ø)

... and 265 files with indirect coverage changes

@pichlermarc pichlermarc added this pull request to the merge queue Sep 26, 2024
Merged via the queue into open-telemetry:main with commit a5dade5 Sep 26, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants