-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(instrumentation-http): add server attributes after they become available #5081
Merged
pichlermarc
merged 4 commits into
open-telemetry:main
from
dynatrace-oss-contrib:fix/server-metrics
Oct 23, 2024
Merged
fix(instrumentation-http): add server attributes after they become available #5081
pichlermarc
merged 4 commits into
open-telemetry:main
from
dynatrace-oss-contrib:fix/server-metrics
Oct 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5081 +/- ##
==========================================
- Coverage 93.27% 93.26% -0.02%
==========================================
Files 317 317
Lines 8195 8195
Branches 1641 1641
==========================================
- Hits 7644 7643 -1
- Misses 551 552 +1 |
Nice! When will this be released on NPM? Just asking, because I noticed that #5079 was not released yet, only merged. Not sure what the current state is. |
trentm
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
While reviewing #5079 I noticed that we don't set
http.route
andhttp.response.status
code in the server duration metrics, so this PR addresses a few problems:http.route
to theSpan
on "new" metricshttp.route
only whenDUPLICATE
emission is turned on becausehttp.response.status
code, becauseNOTE: skipping changelog because this is a bug in an unreleased feature
Supersedes #5079
Related to #5026
Type of change
How Has This Been Tested?