-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update prometheus exporter readme with usage and links #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayurkale22
requested review from
bg451,
danielkhan,
markwolff,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
November 11, 2019 22:25
Codecov Report
@@ Coverage Diff @@
## master #521 +/- ##
===========================================
+ Coverage 49.2% 92.48% +43.27%
===========================================
Files 47 146 +99
Lines 1392 7213 +5821
Branches 143 629 +486
===========================================
+ Hits 685 6671 +5986
+ Misses 707 542 -165
|
bg451
approved these changes
Nov 12, 2019
LGTM. Maybe add a step to start prometheus with a docker command? |
dyladan
approved these changes
Nov 13, 2019
draffensperger
approved these changes
Nov 13, 2019
https://opencensus.io/codelabs/prometheus/#0 <= link is already included for setup. |
mayurkale22
force-pushed
the
prom_readme
branch
from
November 14, 2019 18:52
e9d2c3d
to
ab3b5e7
Compare
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
Co-authored-by: Valentin Marchaud <contact@vmarchaud.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
/cc @dyladan