Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(otlp-exporter-base): remove exports that were meant to be internal #5212

Conversation

pichlermarc
Copy link
Member

@pichlermarc pichlermarc commented Nov 27, 2024

Which problem is this PR solving?

Note

these exports are not published yet and were introduced in #5031, so this still counts as a refactor if it is merged before the changes from #5031 are released. 🙂

In #5031 I introduced a few new types and functions, and two of these functions don't really need to be exported:

  • createOtlpExportDelegate
  • createBoundedQueueExportPromiseHandler

This PR removes these exports.

How Has This Been Tested?

  • Unit tests

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.59%. Comparing base (5ad0aa5) to head (5e4bbdc).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5212      +/-   ##
==========================================
+ Coverage   94.58%   94.59%   +0.01%     
==========================================
  Files         314      314              
  Lines        7993     7993              
  Branches     1611     1611              
==========================================
+ Hits         7560     7561       +1     
+ Misses        433      432       -1     

see 1 file with indirect coverage changes

@pichlermarc pichlermarc marked this pull request as ready for review November 27, 2024 16:55
@pichlermarc pichlermarc requested a review from a team as a code owner November 27, 2024 16:55
@pichlermarc pichlermarc added this pull request to the merge queue Nov 27, 2024
Merged via the queue into open-telemetry:main with commit 1249e34 Nov 27, 2024
21 checks passed
@pichlermarc pichlermarc deleted the feat/remove-unused-promise-queue-export branch November 27, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants