Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(semantic-conventions): clarify suggested usage of *unstable* semconv #5256

Merged

Conversation

trentm
Copy link
Contributor

@trentm trentm commented Dec 12, 2024

It is recommended that users (typically instrumentation libraries) of unstable semconv create a local copy of relevant definitions, rather than pinning. Pinning of this package can easily lead to very many versions of the package being installed, which leads to heavy disk usage.

Refs: #5182

It is recommended that users (typically instrumentation libraries) of *unstable*
semconv create a local copy of relevant definitions, rather than pinning.
Pinning of this package can easily lead to very many versions of the package
being installed, which leads to heavy disk usage.

Refs: open-telemetry#5182
@trentm trentm self-assigned this Dec 12, 2024
@trentm trentm requested a review from a team as a code owner December 12, 2024 01:38
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.67%. Comparing base (e97cc2e) to head (8a85757).
Report is 29 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5256      +/-   ##
==========================================
+ Coverage   94.58%   94.67%   +0.08%     
==========================================
  Files         314      315       +1     
  Lines        7993     8012      +19     
  Branches     1611     1617       +6     
==========================================
+ Hits         7560     7585      +25     
+ Misses        433      427       -6     

see 11 files with indirect coverage changes

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for updating the docs 🙂

@pichlermarc pichlermarc added this pull request to the merge queue Dec 12, 2024
Merged via the queue into open-telemetry:main with commit bdee949 Dec 12, 2024
21 checks passed
@trentm trentm deleted the tm-semconv-pref-to-copy-unstable branch December 12, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

decide on advice for use of *unstable* semconv consts: copy or pin dep
3 participants