Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add redis plugin example #534

Merged
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
106 changes: 106 additions & 0 deletions examples/redis/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,106 @@
# Overview

OpenTelemetry Redis Instrumentation allows the user to automatically collect trace data and export them to the backend of choice (we can use Zipkin or Jaeger for this example), to give observability to distributed systems.

This is a simple example that demonstrates tracing calls to a Redis cache via an Express API. The example
shows key aspects of tracing such as
- Root Span (on Client)
- Child Span (on Client)
- Child Span from a Remote Parent (on Server)
- SpanContext Propagation (from Client to Server)
- Span Events
- Span Attributes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please explain a little more on actual example: what operations are we executing and what are the components involved?

## Installation

```sh
$ # from this directory
$ npm install
```

Setup [Zipkin Tracing](https://zipkin.io/pages/quickstart.html)
or
Setup [Jaeger Tracing](https://www.jaegertracing.io/docs/latest/getting-started/#all-in-one)

## Run the Application

### Zipkin

- Start redis via docker

```sh
# from this directory
npm run docker:start
```

- Run the server

```sh
# from this directory
$ npm run zipkin:server
```

- Run the client

```sh
# from this directory
npm run zipkin:client
```

- Cleanup docker

```sh
# from this directory
npm run docker:stop
```

#### Zipkin UI
`zipkin:server` script should output the `traceid` in the terminal (e.g `traceid: 4815c3d576d930189725f1f1d1bdfcc6`).
Go to Zipkin with your browser [http://localhost:9411/zipkin/traces/(your-trace-id)]() (e.g http://localhost:9411/zipkin/traces/4815c3d576d930189725f1f1d1bdfcc6)

<p align="center"><img src="./images/zipkin.jpg?raw=true"/></p>

### Jaeger

- Start redis via docker

```sh
# from this directory
npm run docker:start
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quiestion: if I want to start zipkin and jaeger at the same time, should I run this command twice or can be already omitted. Maybe just add some additional information here ?

```

- Run the server

```sh
# from this directory
$ npm run jaeger:server
```

- Run the client

```sh
# from this directory
npm run jaeger:client
```

- Cleanup docker

```sh
# from this directory
npm run docker:stop
```

#### Jaeger UI

`jaeger:server` script should output the `traceid` in the terminal (e.g `traceid: 4815c3d576d930189725f1f1d1bdfcc6`).
Go to Jaeger with your browser [http://localhost:16686/trace/(your-trace-id)]() (e.g http://localhost:16686/trace/4815c3d576d930189725f1f1d1bdfcc6)

<p align="center"><img src="images/jaeger.jpg?raw=true"/></p>

## Useful links
- For more information on OpenTelemetry, visit: <https://opentelemetry.io/>
- For more information on OpenTelemetry for Node.js, visit: <https://github.com/open-telemetry/opentelemetry-js/tree/master/packages/opentelemetry-node>

## LICENSE

Apache License 2.0
30 changes: 30 additions & 0 deletions examples/redis/client.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
'use strict'

const opentelemetry = require('@opentelemetry/core');
const types = require('@opentelemetry/types');
const config = require('./setup');
config.setupTracerAndExporters('redis-client-service');
const tracer = opentelemetry.getTracer();
const axios = require('axios').default;

function makeRequest() {
const span = tracer.startSpan('client.makeRequest()', {
parent: tracer.getCurrentSpan(),
kind: types.SpanKind.CLIENT
});

tracer.withSpan(span, async () => {
try {
const res = await axios.get('http://localhost:8080/run_test');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you replace axios with standard http to avoid 3rd parties ?

Copy link
Member Author

@markwolff markwolff Nov 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am currently using axios since it removes a lot of the unimportant "noise code" in the sample. Currently nothing interesting happens in client.js other than kicking off the trace, so I would prefer to keep axios here so that the sample highlights the redis usage. WDYT?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My thought was just to have consistency within all the examples and codebase. So far we don't use axios, but rather just standard libraries as then the user can choose what he wants. If that's the way to go then fine I just think we should have consistency :).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually don't mind the use of axios here. In fact, it shows that third party libraries can be used. These are meant to be examples of real world use and almost nobody uses the http library directly. These aren't shipped to customers in the bundle so additional dependencies don't have as big a burden as they do in the packages

span.setStatus({ code: types.CanonicalCode.OK });
console.log(res.statusText);
} catch (e) {
span.setStatus({ code: types.CanonicalCode.UNKNOWN, message: e.message });
}
span.end();
console.log('Sleeping 5 seconds before shutdown to ensure all records are flushed.')
setTimeout(() => { console.log('Completed.'); }, 5000);
});
}

makeRequest();
36 changes: 36 additions & 0 deletions examples/redis/express-tracer-handlers.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
'use strict'

const types = require('@opentelemetry/types');

function getMiddlewareTracer(tracer) {
return function(req, res, next) {
const span = tracer.startSpan(`express.middleware.tracer(${req.method} ${req.path})`, {
parent: tracer.getCurrentSpan(),
kind: types.SpanKind.SERVER,
});

// End this span before sending out the response
const originalSend = res.send;
res.send = function send() {
span.end();
originalSend.apply(res, arguments);
}

tracer.withSpan(span, next);
}
}

function getErrorTracer(tracer) {
return function(err, _req, res, _next) {
console.log('Caught error', err.message);
const span = tracer.getCurrentSpan();
if (span) {
span.setStatus({ code: types.CanonicalCode.INTERNAL, message: err.message });
}
res.status(500).send(err.message);
}
}

module.exports = {
getMiddlewareTracer, getErrorTracer
}
Binary file added examples/redis/images/jaeger.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added examples/redis/images/zipkin.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
49 changes: 49 additions & 0 deletions examples/redis/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
{
"name": "redis-example",
"private": true,
"version": "0.2.0",
"description": "Example of HTTP integration with OpenTelemetry",
"main": "index.js",
"scripts": {
"docker:start": "docker run -d -p 6379:6379 --name otjsredis redis:alpine",
"docker:stop": "docker stop otjsredis && docker rm otjsredis",
"zipkin:server": "cross-env EXPORTER=zipkin node ./server.js",
"zipkin:client": "cross-env EXPORTER=zipkin node ./client.js",
"jaeger:server": "cross-env EXPORTER=jaeger node ./server.js",
"jaeger:client": "cross-env EXPORTER=jaeger node ./client.js"
},
"repository": {
"type": "git",
"url": "git+ssh://git@github.com/open-telemetry/opentelemetry-js.git"
},
"keywords": [
"opentelemetry",
"http",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"http",
"redis",

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 67b46cc

"tracing"
],
"engines": {
"node": ">=8"
},
"author": "OpenTelemetry Authors",
"license": "Apache-2.0",
"bugs": {
"url": "https://github.com/open-telemetry/opentelemetry-js/issues"
},
"dependencies": {
"@opentelemetry/core": "^0.2.0",
"@opentelemetry/exporter-jaeger": "^0.2.0",
"@opentelemetry/exporter-zipkin": "^0.2.0",
"@opentelemetry/node": "^0.2.0",
"@opentelemetry/plugin-http": "^0.2.0",
"@opentelemetry/plugin-redis": "^0.2.0",
"@opentelemetry/tracing": "^0.2.0",
"@opentelemetry/types": "^0.2.0",
"axios": "^0.19.0",
"express": "^4.17.1",
"redis": "^2.8.0"
},
"homepage": "https://github.com/open-telemetry/opentelemetry-js#readme",
"devDependencies": {
"cross-env": "^6.0.0"
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing new line

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 67b46cc

62 changes: 62 additions & 0 deletions examples/redis/server.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
'use strict';

// Setup opentelemetry tracer first so that built-in plugins can hook onto their corresponding modules
const opentelemetry = require('@opentelemetry/core');
const config = require('./setup');
config.setupTracerAndExporters('redis-server-service');
const tracer = opentelemetry.getTracer();

// Require in rest of modules
const express = require('express');
const axios = require('axios').default;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you replace axios with standard http to avoid 3rd parties ?

const tracerHandlers = require('./express-tracer-handlers');

// Setup express
const app = express();
const PORT = 8080;

/**
* Redis Routes are set up async since we resolve the client once it is successfully connected
*/
async function setupRoutes() {
const redis = await require('./setup-redis').redis;

app.get('/run_test', async (req, res) => {
const uuid = Math.random().toString(36).substring(2, 15) + Math.random().toString(36).substring(2, 15);
await axios.get(`http://localhost:${PORT}/set?args=uuid,${uuid}`);
const body = await axios.get(`http://localhost:${PORT}/get?args=uuid`);

if (body.data !== uuid) {
throw new Error('UUID did not match!');
} else {
res.sendStatus(200);
}
});

app.get('/:cmd', (req, res) => {
if (!req.query.args) {
res.status(400).send('No args provided');
return;
}

const cmd = req.params.cmd;
const args = req.query.args.split(',');
redis[cmd].call(redis, ...args, (err, result) => {
if (err) {
res.sendStatus(400);
} else if(result) {
res.status(200).send(result);
} else {
throw new Error('Empty redis response');
}
});
});
}

// Setup express routes & middleware
app.use(tracerHandlers.getMiddlewareTracer(tracer));
setupRoutes().then(() => {
app.use(tracerHandlers.getErrorTracer(tracer));
app.listen(PORT);
console.log(`Listening on http://localhost:${PORT}`)
});
13 changes: 13 additions & 0 deletions examples/redis/setup-redis.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
const redis = require('redis');

const client = redis.createClient('redis://localhost:6379');
const redisPromise = new Promise(function(resolve, reject) {
client.once('ready', () => {
resolve(client);
});
client.once('error', (error) => {
reject(error);
});
});

exports.redis = redisPromise;
41 changes: 41 additions & 0 deletions examples/redis/setup.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
'use strict';

const opentelemetry = require('@opentelemetry/core');
const { NodeTracer } = require('@opentelemetry/node');
const { SimpleSpanProcessor } = require('@opentelemetry/tracing');
const { JaegerExporter } = require('@opentelemetry/exporter-jaeger');
const { ZipkinExporter } = require('@opentelemetry/exporter-zipkin');
const EXPORTER = process.env.EXPORTER || '';

function setupTracerAndExporters(service) {
const tracer = new NodeTracer({
plugins: {
http: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default, http plugins is enabled with correct path, do you still want to add here? Once #503 merged, will add that into default supported plugins list.

Copy link
Member Author

@markwolff markwolff Nov 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I specify redis plugin here, will that "overwrite" the default list and only load the redis plugin and not any other default plugins? Ultimately this is all moot once redis becomes a default plugin, so I'm fine with blocking this until it becomes default (and making this just a default new NodeTracer())

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes the plugins object overwrites the default, it does not merge with it. In any case, the redis plugin is now in the default list anyways so this doesn't matter.

enabled: true,
},
redis: {
enabled: true,
}
}
});

let exporter;
if (EXPORTER.toLowerCase().startsWith('z')) {
exporter = new ZipkinExporter({
serviceName: service,
});
} else {
exporter = new JaegerExporter({
serviceName: service,
// The default flush interval is 5 seconds.
flushInterval: 2000
});
}

tracer.addSpanProcessor(new SimpleSpanProcessor(exporter));

// Initialize the OpenTelemetry APIs to use the BasicTracer bindings
opentelemetry.initGlobalTracer(tracer);
}

exports.setupTracerAndExporters = setupTracerAndExporters;