-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugin-http): add/modify attributes #643
Merged
mayurkale22
merged 4 commits into
open-telemetry:master
from
VilledeMontreal:feature/add-new-attributes
Jan 2, 2020
Merged
feat(plugin-http): add/modify attributes #643
mayurkale22
merged 4 commits into
open-telemetry:master
from
VilledeMontreal:feature/add-new-attributes
Jan 2, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes open-telemetry#373, open-telemetry#394 Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
Codecov Report
@@ Coverage Diff @@
## master #643 +/- ##
==========================================
- Coverage 92.19% 91.51% -0.68%
==========================================
Files 191 193 +2
Lines 9699 10021 +322
Branches 875 910 +35
==========================================
+ Hits 8942 9171 +229
- Misses 757 850 +93
|
OlivierAlbertini
requested review from
bg451,
dyladan,
markwolff,
mayurkale22,
obecny,
rochdev and
vmarchaud
as code owners
December 21, 2019 22:43
refactor: remove useless checks test: add assertions Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
vmarchaud
approved these changes
Dec 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
mayurkale22
reviewed
Dec 23, 2019
mayurkale22
approved these changes
Dec 23, 2019
dyladan
approved these changes
Dec 30, 2019
dyladan
added
the
Merge:LGTM
This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.)
label
Dec 30, 2019
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
… for bubbled events (open-telemetry#643) Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
Merge:LGTM
This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
Those method should be reused for the http2 plugin.
New specs comes with new network/http attributes
http.ts
is more readable since we use those functions (in http plugin)We also set some attributes sooner (before waiting the response)
After reading new specs, http plugin need to update
parseResponseStatus
function...I created #642