-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add version script to all packages #651
chore: add version script to all packages #651
Conversation
Created this PR to simplify the tracer registry PR which is growing quite large |
Codecov Report
@@ Coverage Diff @@
## master #651 +/- ##
==========================================
- Coverage 89.93% 89.77% -0.16%
==========================================
Files 191 213 +22
Lines 10182 10103 -79
Branches 928 929 +1
==========================================
- Hits 9157 9070 -87
- Misses 1025 1033 +8
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT, however i believe it would be easier to maintain if we add a scripts
folder at the root of the repo
@vmarchaud I moved the version script to the root. Definitely agree this makes it easier to maintain. |
@open-telemetry/javascript-approvers This is blocking #582 so I would appreciate it if we could get this in fairly quickly. It's a pretty simple change and most of the files are autogenerated. |
@obecny can you take a look when you get a moment. Since this was initially an issue you made and you wrote the original implementation for core, I feel like I need your feedback before I can merge this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please add version:update
in main lerna so it can be run from main folder once for all ?
I was thinking about adding a test to check if all version files were regenerated correctly to be run on circleCi. The main reason for that is that it might be forgotten to regenerate it before commit (happened already).
This could be achieved probably by one bash script, which will check git changes before , run version:update
and check if any changes has been done. But that was just the idea and can be done in separate PR.
Other than that lgtm.
yep no problem
Is it easier to do that, or just make a preversion script in each package.json? Agree this can be a separate PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Which problem is this PR solving?
Short description of the changes