Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: skip david-dm.org url from docs-test #660

Merged
merged 4 commits into from
Jan 13, 2020

Conversation

mayurkale22
Copy link
Member

Which problem is this PR solving?

  • https://david-dm.org/ services (both website and badges) are generally fine, but it occasionally suffers. It causes our CircleCI builds to fail, this PR will skip checking the david urls from docs-test job.

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, however we are loosing validating the links for david-dm.org when this service is working fine. I wonder if there is any way to ignore checking only when this service is not working correctly ?

@codecov-io
Copy link

codecov-io commented Jan 3, 2020

Codecov Report

Merging #660 into master will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #660      +/-   ##
=========================================
+ Coverage   89.74%   89.8%   +0.05%     
=========================================
  Files         214     213       -1     
  Lines       10164   10161       -3     
  Branches      929     931       +2     
=========================================
+ Hits         9122    9125       +3     
+ Misses       1042    1036       -6
Impacted Files Coverage Δ
...kages/opentelemetry-plugin-dns/test/utils/utils.ts 33.33% <0%> (-26.67%) ⬇️
packages/opentelemetry-plugin-dns/src/version.ts 100% <0%> (ø) ⬆️
...telemetry-plugin-grpc/test/utils/assertionUtils.ts 100% <0%> (ø) ⬆️
.../opentelemetry-plugin-dns/test/utils/assertSpan.ts 100% <0%> (ø) ⬆️
...in-postgres/opentelemetry-plugin-pg/src/version.ts 100% <0%> (ø) ⬆️
...try-plugin-dns/test/functionals/dns-enable.test.ts 100% <0%> (ø) ⬆️
...try-node/test/instrumentation/PluginLoader.test.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-plugin-grpc/src/version.ts 100% <0%> (ø) ⬆️
...es/opentelemetry-exporter-collector/test/helper.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-node/src/config.ts
... and 2 more

@mayurkale22
Copy link
Member Author

lgtm, however we are loosing validating the links for david-dm.org when this service is working fine. I wonder if there is any way to ignore checking only when this service is not working correctly ?

Hmm good point, I was tring to see if we can skip based on the error code (502 - bad gateway) - looks like this option is not available with linkinator. Let me know if you have better solution to handle this.

@mayurkale22
Copy link
Member Author

I think we should merge this one, david-dm.org is down again.

@mayurkale22 mayurkale22 merged commit 3496744 into open-telemetry:master Jan 13, 2020
@mayurkale22 mayurkale22 deleted the skip_linkinator branch January 13, 2020 23:23
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants