-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: skip david-dm.org url from docs-test #660
chore: skip david-dm.org url from docs-test #660
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, however we are loosing validating the links for david-dm.org when this service is working fine. I wonder if there is any way to ignore checking only when this service is not working correctly ?
Codecov Report
@@ Coverage Diff @@
## master #660 +/- ##
=========================================
+ Coverage 89.74% 89.8% +0.05%
=========================================
Files 214 213 -1
Lines 10164 10161 -3
Branches 929 931 +2
=========================================
+ Hits 9122 9125 +3
+ Misses 1042 1036 -6
|
Hmm good point, I was tring to see if we can skip based on the error code (502 - bad gateway) - looks like this option is not available with |
I think we should merge this one, david-dm.org is down again. |
9396061
to
0a90887
Compare
7771b17
to
4fb4564
Compare
Which problem is this PR solving?