Release process #661
Merged
Release process #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayurkale22
requested review from
bg451,
dyladan,
markwolff,
obecny,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
dyladan
reviewed
Jan 3, 2020
|
|
||
| Merge the PR, and pull the changes locally (using the commands in the first step). Ensure that `chore: x.y.z release proposal` is the most recent commit. | ||
|
|
||
| ## Publish all packages |
There was a problem hiding this comment.
Does this need to be a manual process? Why can we not use lerna publish for this?
There was a problem hiding this comment.
So instead of npm publish on all the packages, just use lerna publish?
There was a problem hiding this comment.
So instead of npm publish on all the packages, just use lerna publish?
I believe that lerna publish from-package should do the same at that point.
Codecov Report
@@ Coverage Diff @@
## master #661 +/- ##
==========================================
+ Coverage 91.66% 92.67% +1.01%
==========================================
Files 217 228 +11
Lines 10305 10361 +56
Branches 915 933 +18
==========================================
+ Hits 9446 9602 +156
+ Misses 859 759 -100
|
OlivierAlbertini
approved these changes
Jan 5, 2020
|
|
||
| Merge the PR, and pull the changes locally (using the commands in the first step). Ensure that `chore: x.y.z release proposal` is the most recent commit. | ||
|
|
||
| ## Publish all packages |
There was a problem hiding this comment.
So instead of npm publish on all the packages, just use lerna publish?
I believe that lerna publish from-package should do the same at that point.
mayurkale22
force-pushed
the
RELEASING.md
branch
from
7c41b08
to
45979d8
Compare
dyladan
approved these changes
Jan 8, 2020
dyladan
added
the
Merge:LGTM
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
…ry#661) Co-authored-by: William Armiros <54150514+willarmiros@users.noreply.github.com> Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?