-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(getting-started): Added a TypeScript version for Getting Started Guide #673
Conversation
Codecov Report
@@ Coverage Diff @@
## master #673 +/- ##
==========================================
- Coverage 94.97% 89.83% -5.14%
==========================================
Files 187 213 +26
Lines 8867 10177 +1310
Branches 771 933 +162
==========================================
+ Hits 8421 9143 +722
- Misses 446 1034 +588
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Co-Authored-By: Mayur Kale <mayurkale@google.com>
Co-Authored-By: Mayur Kale <mayurkale@google.com>
Co-Authored-By: Mayur Kale <mayurkale@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the tracing.ts
file, but I don't see where it is imported by app.ts
.
It is not, it is ran by a command |
@dyladan @mayurkale22 re-requested the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. added few comments.
Which problem is this PR solving?
Short description of the changes