Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 0.3.3 release proposal #683

Merged
merged 3 commits into from
Jan 22, 2020

Conversation

mayurkale22
Copy link
Member

@mayurkale22 mayurkale22 commented Jan 10, 2020

Which problem is this PR solving?

@codecov-io
Copy link

codecov-io commented Jan 10, 2020

Codecov Report

Merging #683 into master will decrease coverage by 1.59%.
The diff coverage is 41.66%.

@@           Coverage Diff            @@
##           master    #683     +/-   ##
========================================
- Coverage    92.7%   91.1%   -1.6%     
========================================
  Files         228     225      -3     
  Lines       10425   10462     +37     
  Branches      939     966     +27     
========================================
- Hits         9664    9531    -133     
- Misses        761     931    +170
Impacted Files Coverage Δ
packages/opentelemetry-plugin-dns/src/version.ts 100% <ø> (ø) ⬆️
packages/opentelemetry-plugin-http/src/version.ts 100% <ø> (ø) ⬆️
...in-postgres/opentelemetry-plugin-pg/src/version.ts 100% <ø> (ø) ⬆️
packages/opentelemetry-plugin-grpc/src/version.ts 100% <ø> (ø) ⬆️
...ges/opentelemetry-scope-async-hooks/src/version.ts 0% <0%> (ø) ⬆️
packages/opentelemetry-plugin-https/src/version.ts 0% <0%> (ø) ⬆️
...kages/opentelemetry-exporter-jaeger/src/version.ts 0% <0%> (ø) ⬆️
packages/opentelemetry-tracing/src/version.ts 0% <0%> (ø) ⬆️
packages/opentelemetry-web/src/version.ts 0% <0%> (ø) ⬆️
packages/opentelemetry-metrics/src/version.ts 0% <0%> (ø) ⬆️
... and 56 more

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dyladan
Copy link
Member

dyladan commented Jan 13, 2020

The build failure is a SIGHUP received during the bootstrap phase of the build. Is it possible we are running out of memory on our build node?

@dyladan dyladan added the Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.) label Jan 22, 2020
@mayurkale22
Copy link
Member Author

Any idea why build is failing for node8 job?

@obecny
Copy link
Member

obecny commented Jan 22, 2020

maybe this can help
https://discuss.circleci.com/t/builds-getting-killed-with-vague-message-received-signal-killed/10214/8
If I understand correctly basically try to add cmd: ["/bin/bash"] to config.yml
Haven't tried that though

  node8:
    docker:
      - image: node:8
        environment: *node_test_env
        cmd: ["/bin/bash"]
      - *postgres_service
      - *mysql_service
      - *redis_service
      - *mongo_service
    <<: *node_unit_tests

@mayurkale22
Copy link
Member Author

Removed examples/* (added by mistake, earlier) from lerna and build is passed. @dyladan thanks for noticing this :)

@mayurkale22 mayurkale22 merged commit cb677c0 into open-telemetry:master Jan 22, 2020
@mayurkale22 mayurkale22 deleted the 0.3.3-proposal branch January 22, 2020 22:43
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
* chore: 0.3.3 release proposal

* chore: bump propagator-jaeger and exporter-stackdriver-trace version

* remove examples/ from lerna
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants