-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add benchmark README and latest numbers #689
Add benchmark README and latest numbers #689
Conversation
benchmark/tracer.js
Outdated
@@ -21,7 +21,8 @@ const setups = [ | |||
|
|||
for (const setup of setups) { | |||
console.log(`Beginning ${setup.name} Benchmark...`); | |||
const tracer = setup.registry.getTracer("benchmark"); | |||
const registry = setup.registry; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Below line#59 depends on this.
chore: update readme
3e83dd2
to
ccc4a32
Compare
Codecov Report
@@ Coverage Diff @@
## master #689 +/- ##
==========================================
- Coverage 92.7% 91.12% -1.58%
==========================================
Files 227 225 -2
Lines 10346 10541 +195
Branches 934 965 +31
==========================================
+ Hits 9591 9606 +15
- Misses 755 935 +180
|
chore: update readme
a73a9d5
to
3c324ab
Compare
Can you add a noop tracer setup? |
The difference between |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so far npm run bench
fails for me anyway, does it work for you ?
Indeed, after
|
I would suggest the following:
Made mayurkale22#1 so you can see what i'm talking about. |
For web it will be nice to be able to run benchmark in few popular browsers as sometimes the certain browser might be really slow. For that we might use services like https://www.browserstack.com/ for example |
Apply updates suggested in PR comment
Please put the latest numbers in the README after you merged my sub-PR |
Done. |
…etry#689) * fix: add support for setConfig in ioredis instrumentation * fix: use latest config in traceSendCommand * fix: lint errors fixed * fix: remove override setConfig * refactor: ioredis instrumentation refactored moved traceConnection to instrumentation.ts refactored tests to use setConfig instead of new instrumentation
Which problem is this PR solving?
README.md
, please contribute or suggest missing things.