Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix compilation #705

Merged
merged 2 commits into from
Jan 16, 2020

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Jan 16, 2020

Which problem is this PR solving?

  • Solves an issue where the build is broken due to a typing update for pg-pool

@codecov-io
Copy link

codecov-io commented Jan 16, 2020

Codecov Report

Merging #705 into master will decrease coverage by 5.52%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #705      +/-   ##
==========================================
- Coverage   95.11%   89.58%   -5.53%     
==========================================
  Files         187      213      +26     
  Lines        8999    10023    +1024     
  Branches      777      932     +155     
==========================================
+ Hits         8559     8979     +420     
- Misses        440     1044     +604
Impacted Files Coverage Δ
.../opentelemetry-plugin-pg-pool/test/pg-pool.test.ts 34.92% <0%> (-1.15%) ⬇️
packages/opentelemetry-core/test/utils/url.test.ts 50% <0%> (-50%) ⬇️
...pentelemetry-core/test/internal/validators.test.ts 50% <0%> (-50%) ⬇️
...elemetry-core/test/trace/spancontext-utils.test.ts 55.55% <0%> (-44.45%) ⬇️
...lemetry-core/test/trace/ProbabilitySampler.test.ts 56.52% <0%> (-43.48%) ⬇️
...s/opentelemetry-core/test/trace/NoopTracer.test.ts 60% <0%> (-40%) ⬇️
...s/opentelemetry-core/test/context/B3Format.test.ts 63.39% <0%> (-36.61%) ⬇️
...ges/opentelemetry-core/test/trace/NoopSpan.test.ts 63.63% <0%> (-36.37%) ⬇️
...s/opentelemetry-core/test/trace/tracestate.test.ts 65.06% <0%> (-34.94%) ⬇️
...ntelemetry-core/test/trace/NoRecordingSpan.test.ts 71.42% <0%> (-28.58%) ⬇️
... and 66 more

@dyladan dyladan merged commit 0d73dd7 into open-telemetry:master Jan 16, 2020
@dyladan dyladan deleted the compilation-fix branch January 16, 2020 20:41
@draffensperger
Copy link
Contributor

draffensperger commented Jan 16, 2020

How did this get past the CI checks? Is there a way we could have avoided this?

@obecny
Copy link
Member

obecny commented Jan 16, 2020

my only idea is to turn off npm cache when running against master

@dyladan
Copy link
Member Author

dyladan commented Jan 16, 2020

The typings for pg-pool updated and released with a patch version. Because we don't lock versions of the dependency, the CI caught it. This is working as intended IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants