chore: fix pg-pool test env #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiao-lix
requested review from
bg451,
dyladan,
markwolff,
mayurkale22,
obecny,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
Codecov Report
@@ Coverage Diff @@
## master #706 +/- ##
=========================================
Coverage ? 92.64%
=========================================
Files ? 222
Lines ? 10342
Branches ? 925
=========================================
Hits ? 9581
Misses ? 761
Partials ? 0
|
dyladan
approved these changes
Jan 17, 2020
| @@ -94,8 +94,8 @@ describe('pg-pool@2.x', () => { | |||
| let pool: pgPool<pg.Client>; | |||
| const registry = new NodeTracerRegistry(); | |||
| const logger = new NoopLogger(); | |||
| const testPostgres = process.env.TEST_POSTGRES; // For CI: assumes local postgres db is already available | |||
| const testPostgresLocally = process.env.TEST_POSTGRES_LOCAL; // For local: spins up local postgres db via docker | |||
| const testPostgres = process.env.RUN_POSTGRES_TESTS; // For CI: assumes local postgres db is already available | |||
There was a problem hiding this comment.
Does this mean tests have not been running?
There was a problem hiding this comment.
I'm afraid so, but it should been running before test-utils package.
obecny
approved these changes
Jan 17, 2020
mayurkale22
approved these changes
Jan 17, 2020
OlivierAlbertini
approved these changes
Jan 17, 2020
| @@ -54,6 +54,7 @@ | |||
| "@types/pg-pool": "^2.0.1", | |||
| "@types/shimmer": "^1.0.1", | |||
| "codecov": "^3.6.1", | |||
| "cross-env": "^6.0.0", | |||
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
martinkuba
pushed a commit
to martinkuba/opentelemetry-js
that referenced
this pull request
Mar 13, 2024
martinkuba
pushed a commit
to martinkuba/opentelemetry-js
that referenced
this pull request
Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.