-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: return module exports from ioredis #714
Merged
dyladan
merged 2 commits into
open-telemetry:master
from
dynatrace-oss-contrib:ioredis-fix
Jan 21, 2020
Merged
fix: return module exports from ioredis #714
dyladan
merged 2 commits into
open-telemetry:master
from
dynatrace-oss-contrib:ioredis-fix
Jan 21, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyladan
requested review from
bg451,
markwolff,
mayurkale22,
obecny,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
January 21, 2020 01:32
naseemkullah
approved these changes
Jan 21, 2020
Closed
vmarchaud
approved these changes
Jan 21, 2020
OlivierAlbertini
approved these changes
Jan 21, 2020
mayurkale22
approved these changes
Jan 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
mayurkale22
added
the
Merge:LGTM
This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.)
label
Jan 21, 2020
Codecov Report
@@ Coverage Diff @@
## master #714 +/- ##
=========================================
- Coverage 92.74% 91% -1.75%
=========================================
Files 226 222 -4
Lines 10432 10424 -8
Branches 932 953 +21
=========================================
- Hits 9675 9486 -189
- Misses 757 938 +181
|
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
…nstrumentation (open-telemetry#714) Co-authored-by: Rauno Viskus <Rauno56@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
Merge:LGTM
This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #713
Fixes #668