Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: typo in Ville de Montréal #716

Merged
merged 1 commit into from
Jan 21, 2020

Conversation

naseemkullah
Copy link
Member

@codecov-io
Copy link

codecov-io commented Jan 21, 2020

Codecov Report

Merging #716 into master will decrease coverage by 1.3%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #716      +/-   ##
==========================================
- Coverage   92.39%   91.08%   -1.31%     
==========================================
  Files         219      223       +4     
  Lines        9728    10522     +794     
  Branches      875      958      +83     
==========================================
+ Hits         8988     9584     +596     
- Misses        740      938     +198
Impacted Files Coverage Δ
packages/opentelemetry-core/test/utils/url.test.ts 50% <0%> (-50%) ⬇️
...pentelemetry-core/test/internal/validators.test.ts 50% <0%> (-50%) ⬇️
packages/opentelemetry-metrics/src/Meter.ts 96.96% <0%> (ø) ⬆️
...elemetry-core/test/trace/spancontext-utils.test.ts 55.55% <0%> (-44.45%) ⬇️
...lemetry-core/test/trace/ProbabilitySampler.test.ts 56.52% <0%> (-43.48%) ⬇️
...s/opentelemetry-core/test/trace/NoopTracer.test.ts 60% <0%> (-40%) ⬇️
...s/opentelemetry-core/test/context/B3Format.test.ts 63.39% <0%> (-36.61%) ⬇️
...ges/opentelemetry-core/test/trace/NoopSpan.test.ts 63.63% <0%> (-36.37%) ⬇️
...s/opentelemetry-core/test/trace/tracestate.test.ts 65.06% <0%> (-34.94%) ⬇️
...ntelemetry-core/test/trace/NoRecordingSpan.test.ts 71.42% <0%> (-28.58%) ⬇️
... and 176 more

@OlivierAlbertini
Copy link
Member

Thx @naseemkullah

@OlivierAlbertini OlivierAlbertini added document Documentation-related size/XS Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.) and removed Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.) labels Jan 21, 2020
@naseemkullah
Copy link
Member Author

As a fellow Montrealer, my pleasure :)

@dyladan dyladan merged commit 96bfebb into open-telemetry:master Jan 21, 2020
@naseemkullah naseemkullah deleted the patch-1 branch January 21, 2020 14:20
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Co-authored-by: Valentin Marchaud <contact@vmarchaud.fr>
martinkuba pushed a commit to martinkuba/opentelemetry-js that referenced this pull request Mar 13, 2024
Co-authored-by: Valentin Marchaud <contact@vmarchaud.fr>
martinkuba pushed a commit to martinkuba/opentelemetry-js that referenced this pull request Mar 16, 2024
Co-authored-by: Valentin Marchaud <contact@vmarchaud.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants