Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove redundant statement #726

Merged
merged 2 commits into from
Jan 23, 2020
Merged

Conversation

mayurkale22
Copy link
Member

Which problem is this PR solving?

  • The line above this says the same thing.

/cc @dyladan

@mayurkale22 mayurkale22 added document Documentation-related size/XS labels Jan 22, 2020
@mayurkale22 mayurkale22 merged commit 230842f into open-telemetry:master Jan 23, 2020
@mayurkale22 mayurkale22 deleted the dup branch January 23, 2020 21:22
@codecov-io
Copy link

codecov-io commented Jan 23, 2020

Codecov Report

Merging #726 into master will increase coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #726      +/-   ##
==========================================
+ Coverage   90.95%   91.09%   +0.13%     
==========================================
  Files         225      226       +1     
  Lines       10365    10554     +189     
  Branches      958      964       +6     
==========================================
+ Hits         9428     9614     +186     
- Misses        937      940       +3
Impacted Files Coverage Δ
...s/opentelemetry-core/test/trace/NoopTracer.test.ts 60% <0%> (ø) ⬆️
...ntelemetry-core/src/platform/node/hex-to-base64.ts 88.88% <0%> (ø) ⬆️
...lemetry-core/test/trace/ProbabilitySampler.test.ts 56.52% <0%> (ø) ⬆️
...pentelemetry-core/test/internal/validators.test.ts 50% <0%> (ø) ⬆️
...core/src/context/propagation/NoopHttpTextFormat.ts 100% <0%> (ø) ⬆️
...kages/opentelemetry-metrics/test/mocks/Exporter.ts 66.66% <0%> (-33.34%) ⬇️
packages/opentelemetry-core/src/common/types.ts 100% <0%> (ø) ⬆️
...ges/opentelemetry-core/test/trace/NoopSpan.test.ts 63.63% <0%> (ø) ⬆️
...ckages/opentelemetry-core/src/common/NoopLogger.ts 57.14% <0%> (+7.14%) ⬆️
...ages/opentelemetry-plugin-http/test/utils/utils.ts 33.33% <0%> (-26.67%) ⬇️
... and 163 more

pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants