Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: publish docs on all tags #730

Merged

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Jan 23, 2020

As discussed with @mayurkale22 this change makes it so that docs will publish on any new version.

Previously, it ignored patch versions. Because we are changing so quickly, we are not following typical semver patterns and it is important that the docs always represent the latest version.

@codecov-io
Copy link

codecov-io commented Jan 23, 2020

Codecov Report

Merging #730 into master will decrease coverage by 1.88%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #730      +/-   ##
==========================================
- Coverage   92.74%   90.85%   -1.89%     
==========================================
  Files         228      225       -3     
  Lines       10383    10294      -89     
  Branches      938      953      +15     
==========================================
- Hits         9630     9353     -277     
- Misses        753      941     +188
Impacted Files Coverage Δ
packages/opentelemetry-core/test/utils/url.test.ts 50% <0%> (-50%) ⬇️
...pentelemetry-core/test/internal/validators.test.ts 50% <0%> (-50%) ⬇️
...elemetry-core/test/trace/spancontext-utils.test.ts 55.55% <0%> (-44.45%) ⬇️
...lemetry-core/test/trace/ProbabilitySampler.test.ts 56.52% <0%> (-43.48%) ⬇️
...s/opentelemetry-core/test/trace/NoopTracer.test.ts 60% <0%> (-40%) ⬇️
...s/opentelemetry-core/test/context/B3Format.test.ts 63.39% <0%> (-36.61%) ⬇️
...ges/opentelemetry-core/test/trace/NoopSpan.test.ts 63.63% <0%> (-36.37%) ⬇️
...s/opentelemetry-core/test/trace/tracestate.test.ts 65.06% <0%> (-34.94%) ⬇️
...ntelemetry-core/test/trace/NoRecordingSpan.test.ts 71.42% <0%> (-28.58%) ⬇️
...ackages/opentelemetry-core/src/platform/node/id.ts 71.42% <0%> (-28.58%) ⬇️
... and 41 more

Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dyladan dyladan merged commit d3af8c4 into open-telemetry:master Jan 24, 2020
@Flarna Flarna deleted the publish-docs-all-tags branch February 11, 2020 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants