-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fixing documentation for web tracer provider, fixing examples … #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for web, enable manager when registering
obecny
requested review from
bg451,
dyladan,
markwolff,
mayurkale22,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
March 26, 2020 21:16
obecny
added
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
bug
Something isn't working
Target:Browser
labels
Mar 26, 2020
Codecov Report
@@ Coverage Diff @@
## master #906 +/- ##
==========================================
+ Coverage 94.08% 94.48% +0.40%
==========================================
Files 248 248
Lines 10835 10997 +162
Branches 1055 1062 +7
==========================================
+ Hits 10194 10391 +197
+ Misses 641 606 -35
|
mayurkale22
approved these changes
Mar 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for fixing this.
obecny
added
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
and removed
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
labels
Mar 27, 2020
added more fixes - point 5 |
vmarchaud
approved these changes
Mar 27, 2020
dyladan
approved these changes
Mar 27, 2020
dyladan
pushed a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
…en-telemetry#906) * chore: fixing documentation for web tracer provider, fixing examples for web, enable manager when registering * chore: fixing span extraction from zone after context updates * chore: bump
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
martinkuba
pushed a commit
to martinkuba/opentelemetry-js
that referenced
this pull request
Mar 13, 2024
martinkuba
pushed a commit
to martinkuba/opentelemetry-js
that referenced
this pull request
Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…for web, enable manager when registering
Which problem is this PR solving?
Short description of the changes
register
Without this the manager is being created but in fact it never works and it was quite difficult to finally figure out what was wrong. This way the simplified form of creating new context manager will be easier for a user
for example this wasn't working - the zone was disabled, now it will be enabled
provider.register({ contextManager: new ZoneContextManager(), });
I have also added checking in constructor to throw an error if someone adds either contextManager or propagator into
constructor
instead ofregister
- as it is currently shown in out documentation for web. This way user will now faster what is wrong.