-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove label set from metrics API #915
Merged
mayurkale22
merged 4 commits into
open-telemetry:master
from
mayurkale22:remove_labelset
Apr 1, 2020
Merged
Remove label set from metrics API #915
mayurkale22
merged 4 commits into
open-telemetry:master
from
mayurkale22:remove_labelset
Apr 1, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayurkale22
requested review from
bg451,
dyladan,
markwolff,
obecny,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
March 30, 2020 22:48
mayurkale22
added
API
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
Mar 30, 2020
dyladan
approved these changes
Mar 31, 2020
markwolff
approved these changes
Mar 31, 2020
vmarchaud
approved these changes
Apr 1, 2020
dyladan
added
the
Merge:LGTM
This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.)
label
Apr 1, 2020
Codecov Report
@@ Coverage Diff @@
## master #915 +/- ##
===========================================
+ Coverage 78.62% 94.95% +16.32%
===========================================
Files 73 247 +174
Lines 1736 11153 +9417
Branches 300 1067 +767
===========================================
+ Hits 1365 10590 +9225
- Misses 371 563 +192
|
dyladan
pushed a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
* metrics: remove LabeSet API * fix: tests * fix: lint
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
* supprt responsehook config * add specs * response hook receives an info object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Merge:LGTM
This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.)
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
https://github.com/open-telemetry/oteps/blob/master/text/0090-remove-labelset-from-metrics-api.md