Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove label set from metrics API #915

Merged
merged 4 commits into from
Apr 1, 2020

Conversation

mayurkale22
Copy link
Member

Which problem is this PR solving?

Short description of the changes

@mayurkale22 mayurkale22 added API size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 30, 2020
@dyladan dyladan added the Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.) label Apr 1, 2020
@codecov-io
Copy link

codecov-io commented Apr 1, 2020

Codecov Report

Merging #915 into master will increase coverage by 16.32%.
The diff coverage is 93.06%.

@@             Coverage Diff             @@
##           master     #915       +/-   ##
===========================================
+ Coverage   78.62%   94.95%   +16.32%     
===========================================
  Files          73      247      +174     
  Lines        1736    11153     +9417     
  Branches      300     1067      +767     
===========================================
+ Hits         1365    10590     +9225     
- Misses        371      563      +192     
Impacted Files Coverage Δ
packages/opentelemetry-api/src/metrics/Metric.ts 100.00% <ø> (ø)
packages/opentelemetry-metrics/src/Meter.ts 96.29% <ø> (ø)
packages/opentelemetry-metrics/src/export/types.ts 100.00% <ø> (ø)
...ackages/opentelemetry-api/src/metrics/NoopMeter.ts 72.72% <28.57%> (-1.75%) ⬇️
packages/opentelemetry-metrics/src/Metric.ts 96.66% <88.23%> (ø)
...y-api/test/noop-implementations/noop-meter.test.ts 100.00% <100.00%> (ø)
...pentelemetry-exporter-prometheus/src/prometheus.ts 92.00% <100.00%> (ø)
...emetry-exporter-prometheus/test/prometheus.test.ts 98.70% <100.00%> (ø)
...kages/opentelemetry-metrics/src/BoundInstrument.ts 92.85% <100.00%> (ø)
...ckages/opentelemetry-metrics/src/ObserverResult.ts 100.00% <100.00%> (ø)
... and 190 more

@mayurkale22 mayurkale22 merged commit 3d26f82 into open-telemetry:master Apr 1, 2020
@mayurkale22 mayurkale22 deleted the remove_labelset branch April 1, 2020 19:36
dyladan pushed a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
* metrics: remove LabeSet API

* fix: tests

* fix: lint
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
* supprt responsehook config

* add specs

* response hook receives an info object
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.) size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove label set from metrics API
5 participants