Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: removing force flush #916

Merged
merged 3 commits into from
Apr 1, 2020
Merged

chore: removing force flush #916

merged 3 commits into from
Apr 1, 2020

Conversation

obecny
Copy link
Member

@obecny obecny commented Mar 31, 2020

Which problem is this PR solving?

@obecny obecny self-assigned this Mar 31, 2020
@obecny obecny added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 31, 2020
mayurkale22
mayurkale22 approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-io
Copy link

codecov-io commented Mar 31, 2020 •
edited
Loading

Codecov Report

Merging #916 into master will decrease coverage by 17.21%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #916       +/-   ##
===========================================
- Coverage   94.95%   77.73%   -17.22%     
===========================================
  Files         247       74      -173     
  Lines       11153     1752     -9401     
  Branches     1067      300      -767     
===========================================
- Hits        10590     1362     -9228     
+ Misses        563      390      -173
Impacted Files Coverage Δ
packages/opentelemetry-core/test/utils/url.test.ts 0.00% <0.00%> (-100.00%) ⬇️
...ckages/opentelemetry-core/test/platform/id.test.ts 0.00% <0.00%> (-100.00%) ⬇️
...pentelemetry-core/src/platform/node/performance.ts 0.00% <0.00%> (-100.00%) ⬇️
...pentelemetry-core/test/internal/validators.test.ts 0.00% <0.00%> (-100.00%) ⬇️
...ntelemetry-core/test/trace/NoRecordingSpan.test.ts 0.00% <0.00%> (-100.00%) ⬇️
...telemetry-core/test/platform/hex-to-base64.test.ts 0.00% <0.00%> (-100.00%) ⬇️
...elemetry-core/test/trace/spancontext-utils.test.ts 0.00% <0.00%> (-100.00%) ⬇️
...lemetry-core/test/trace/ProbabilitySampler.test.ts 0.00% <0.00%> (-100.00%) ⬇️
...try-core/test/trace/fixtures/test-package/index.js 0.00% <0.00%> (-100.00%) ⬇️
...ry-api/test/noop-implementations/noop-span.test.ts 0.00% <0.00%> (-100.00%) ⬇️
... and 173 more

dyladan
dyladan approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this

vmarchaud
vmarchaud approved these changes Apr 1, 2020
View reviewed changes
Copy link
Member

@vmarchaud vmarchaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mayurkale22 mayurkale22 added the Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.) label Apr 1, 2020
@mayurkale22 mayurkale22 merged commit 7719c91 into open-telemetry:master Apr 1, 2020
@obecny obecny deleted the jeager_force_flush branch October 1, 2020 14:18
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
@chrisrichardsevergreen
feat(aws-sdk): lambda client instrumentation (open-telemetry#916)
dc6c2b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayurkale22 mayurkale22 mayurkale22 approved these changes

@vmarchaud vmarchaud vmarchaud approved these changes

@dyladan dyladan dyladan approved these changes

@bg451 bg451 Awaiting requested review from bg451

@markwolff markwolff Awaiting requested review from markwolff

@OlivierAlbertini OlivierAlbertini Awaiting requested review from OlivierAlbertini

@rochdev rochdev Awaiting requested review from rochdev

Assignees

@obecny obecny

Labels
Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.) size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove forceFlush from Jaeger exporter
5 participants
@obecny @codecov-io @dyladan @vmarchaud @mayurkale22