-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: adding example for collector-exporter for node with opentelemetry-collector #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obecny
requested review from
bg451,
dyladan,
markwolff,
mayurkale22,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
April 10, 2020 12:40
obecny
added
the
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
label
Apr 10, 2020
Codecov Report
@@ Coverage Diff @@
## master #958 +/- ##
==========================================
+ Coverage 94.75% 95.44% +0.68%
==========================================
Files 248 84 -164
Lines 11288 5044 -6244
Branches 1079 495 -584
==========================================
- Hits 10696 4814 -5882
+ Misses 592 230 -362 |
dyladan
approved these changes
Apr 10, 2020
vmarchaud
reviewed
Apr 10, 2020
vmarchaud
approved these changes
Apr 10, 2020
gts install is failing because typescript isn't installed first it looks like. Might have to do it in two separate |
mayurkale22
reviewed
Apr 10, 2020
mayurkale22
reviewed
Apr 10, 2020
mayurkale22
approved these changes
Apr 10, 2020
is this ready to merge ? |
I think we should merge this one first to rebase every other PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding example for easier testing for collector-exporter with opentelemetry-collector using the latest image that supports new proto format with grpc