-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: merge opentelemetry-base to opentelemetry-core #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legendecas
requested review from
bg451,
dyladan,
markwolff,
mayurkale22,
obecny,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
April 29, 2020 05:00
Please fix the build. |
mayurkale22
reviewed
Apr 29, 2020
Codecov Report
@@ Coverage Diff @@
## master #991 +/- ##
==========================================
+ Coverage 94.90% 94.92% +0.02%
==========================================
Files 212 212
Lines 8676 8671 -5
Branches 791 792 +1
==========================================
- Hits 8234 8231 -3
+ Misses 442 440 -2
|
They act a very similar role in the SDK.
@mayurkale22 Test fixed :) |
mayurkale22
approved these changes
Apr 29, 2020
dyladan
approved these changes
Apr 29, 2020
vmarchaud
approved these changes
Apr 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
@opentelemetry/api
and@opentelemetry/core
.Short description of the changes
@opentelemetry/base
to@opentelemetry/core