Skip to content

Commit

Permalink
feat: add default appProtocol on oc receiver (#2486)
Browse files Browse the repository at this point in the history
* feat: add default appProtocol on oc receiver

Signed-off-by: Husni Alhamdani <dhanielluis@gmail.com>

* feat: add default appProtocol on oc receiver

Signed-off-by: Husni Alhamdani <dhanielluis@gmail.com>

* feat: add default appProtocol on oc receiver

Signed-off-by: Husni Alhamdani <dhanielluis@gmail.com>

---------

Signed-off-by: Husni Alhamdani <dhanielluis@gmail.com>
  • Loading branch information
husnialhamdani authored Jan 4, 2024
1 parent f508392 commit 1b6d009
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 5 deletions.
16 changes: 16 additions & 0 deletions .chloggen/main.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: bug_fix

# The name of the component, or a single word describing the area of concern, (e.g. operator, target allocator, github action)
component: operator

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: add missing appProtocol in opencensus receiver

# One or more tracking issues related to the change
issues: [2487]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:
12 changes: 7 additions & 5 deletions internal/manifests/collector/parser/receiver/receiver_oc.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,14 @@ const parserNameOpenCensus = "__opencensus"

// NewOpenCensusReceiverParser builds a new parser for OpenCensus receivers.
func NewOpenCensusReceiverParser(logger logr.Logger, name string, config map[interface{}]interface{}) parser.ComponentPortParser {
httpAppProtocol := "http"
return &GenericReceiver{
logger: logger,
name: name,
config: config,
defaultPort: 55678,
parserName: parserNameOpenCensus,
logger: logger,
name: name,
config: config,
defaultPort: 55678,
parserName: parserNameOpenCensus,
defaultAppProtocol: &httpAppProtocol,
}
}

Expand Down

0 comments on commit 1b6d009

Please sign in to comment.