Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

container names annotations don't work for for sdk, apache, nginx #3313

Closed
Joibel opened this issue Sep 30, 2024 · 2 comments
Closed

container names annotations don't work for for sdk, apache, nginx #3313

Joibel opened this issue Sep 30, 2024 · 2 comments
Labels
bug Something isn't working needs triage

Comments

@Joibel
Copy link
Contributor

Joibel commented Sep 30, 2024

Component(s)

auto-instrumentation

What happened?

Description

This is just an issue to cover #3307 as I need an issue for the changelog.

Steps to Reproduce

Attempt to use the container names annotations for the 3 affected injectors

Expected Result

They inject into the appropriate containers

Actual Result

The annotations are ignored

Kubernetes Version

1.28

Operator version

v0.109.0

Collector version

Irrelevent

Environment information

Environment

OS: (e.g., "Ubuntu 20.04")
Compiler(if manually compiled): (e.g., "go 14.2")

Log output

No response

Additional context

No response
@Joibel Joibel added bug Something isn't working needs triage labels Sep 30, 2024
@jaronoff97
Copy link
Contributor

closed by #3307

@jaronoff97
Copy link
Contributor

thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working needs triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Joibel @jaronoff97