fix: fix container names annotations for sdk, apache, nginx #3307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found through code inspection, the ApacheHttpd, Nginx and SDK injectors do not honor their container-names annotations. This is a breaking change if anyone is using the enablement flag with container names for these 3 injectors, which I believe would work as truthy would treat a list of container names as true. Signed-off-by: Alan Clucas <alan@clucas.org>
iblancasa
approved these changes
Sep 27, 2024
|
@Joibel Thanks for the fix, I'll update the tests after this fix. |
|
What I find worrisome is that changing this doesn't fail any tests. Could you add a unit test? Ideally, we'd also have an e2e test exercise this function. |
Yes, I will do. |
Signed-off-by: Alan Clucas <alan@clucas.org>
|
I've added a changelog. I'm not that familiar with the tests - I could possibly write one but it looks like @IshwarKanse has offered so I'll leave it with them. |
swiatekm
approved these changes
Sep 30, 2024
This was referenced Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found through code inspection, the ApacheHttpd, Nginx and SDK injectors do not honour their container-names annotations.
I have changed the annotation used for the container list to match the expected annotation constant which already existed in each case but was unused in the code base.
This is a breaking change if anyone is using the enablement flag with container names for these 3 injectors, which I believe would work as truthy would treat a list of container names as true.