Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't checkin autogenerated resources #522

Closed
anuraaga opened this issue Nov 10, 2021 · 5 comments
Closed

Don't checkin autogenerated resources #522

anuraaga opened this issue Nov 10, 2021 · 5 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@anuraaga
Copy link
Contributor

It's quite difficult to develop on this repo since it's basically not possible to have code in a state where it builds locally and CI equally. This is because of version and kustomize manifests which reflects the git state - a local build requires a different value committed to be able to run, but this then causes the CI to not run and needs to be reverted. Most problematic is that make bundle does generate some files that do need to be committed for the CI to run, namely the ones reflecting the CRD. So I find myself make bundle and finding the files to revert before pushing code.

Is it possible to just run autogeneration as part of a build without having to check them into the repo?

@pavolloffay
Copy link
Member

I agree with you that it's annoying how it is setup right now. At the same time I like that generated valid CRD is committed to the main branch, but perhaps this can be done only for the release commit.

nit I run the following before submitting PR

VERSION=0.38.0 USER=opentelemetry  make bundle 

@pavolloffay
Copy link
Member

Also, I would prefer to keep check-in in all files to be compliant with the sample project https://github.com/operator-framework/operator-sdk/tree/master/testdata/go/v3/memcached-operator.

There are some assuptions that operator-sdk uses and we should be compatible with them.

@anuraaga
Copy link
Contributor Author

Any approach that solves the dance would be fine, if it can support the merged autogen code. I think currently, it's in a really bad place when local code and CI code can't build with the same repo state, or may require some opaque flags.

@yuriolisa yuriolisa added the help wanted Extra attention is needed label Jul 15, 2022
@jaronoff97 jaronoff97 added this to the v1alpha2 CRD release milestone Nov 28, 2023
@jaronoff97
Copy link
Contributor

We should really improve this in preparation for the v2 release, cc @pavolloffay this relates to #1794

@jaronoff97 jaronoff97 added the enhancement New feature or request label Nov 28, 2023
@jaronoff97
Copy link
Contributor

resolved by #2421 and #2479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants