Use kustomize for e2e test setup #2479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiatekm
force-pushed
the
test/e2e-images
branch
5 times, most recently
from
3049f3f
to
cec256f
Compare
swiatekm
force-pushed
the
test/e2e-images
branch
from
cec256f
to
f7a9613
Compare
swiatekm
commented
Dec 27, 2023
Comment on lines
-31
to
+35
| - --enable-leader-election | ||
| - "--metrics-addr=127.0.0.1:8080" | ||
| - "--enable-leader-election" | ||
| - "--zap-log-level=info" | ||
| - "--zap-time-encoding=rfc3339nano" | ||
| - "--feature-gates=+operator.autoinstrumentation.go,+operator.autoinstrumentation.nginx" |
There was a problem hiding this comment.
I moved this so I could patch these args in the manager kustomization.yaml, as opposed to the one in config/default. I don't see any reason for it not to be here.
jaronoff97
approved these changes
Dec 27, 2023
| - e2e-pdb | ||
| - e2e-opampbridge | ||
| - e2e-prometheuscr | ||
| - e2e-multi-instrumentation | ||
| include: |
There was a problem hiding this comment.
This is very slick. I like it :)
|
This LGTM. The operator helm chart also runs these E2E tests. Do we need to make any changes there? |
Test run by the Helm Chart should work as they are. This will let us simplify their setup, which can happen in a later change. |
yuriolisa
approved these changes
Dec 28, 2023
pavolloffay
approved these changes
Jan 8, 2024
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
* Use kustomize for setting target allocator image in E2E tests * Use kustomize for setting opamp bridge image in E2E tests * Use kustomize for setting feature gates in E2E tests * Move operator flags to manager manifest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Right now, we have a very ad-hoc and inconsistent way of doing setup for e2e tests:
This change introduces a single mechanism for e2e test setup. All the per-testsuite setup is done via kustomize, primarily through json patches on the operator args - both images and feature gates can be set this way.
As a result, we have:
prepare-e2emake target, or its flavorsconfig/manager/kustomization.yamlfile, which makes them easy to controlTesting:
Went through a bunch of typical dev workflows manually.