Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RBAC Support for loadbalancingExporter #3104

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add RBAC Support for loadbalancingExporter #3104

wants to merge 3 commits into from

Conversation

fyuan1316
Copy link
Contributor

Description:

  • Support RBAC for component loadbalancingExporter (for k8s resolver).
  • Add support for RBAC for Role and RoleBinding resources.

Link to tracking Issue(s):

Testing:

Documentation:

@fyuan1316 fyuan1316 requested a review from a team July 4, 2024 15:40
@jaronoff97
Copy link
Contributor

@fyuan1316 i think we may want to hold off on this until #3069 is merged which changes and improves some of this functionality.

frzifus
frzifus reviewed Sep 3, 2024
View reviewed changes
Copy link
Member

@frzifus frzifus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats the state here? @fyuan1316 @jaronoff97

@jaronoff97
Copy link
Contributor

@fyuan1316 i have this PR #3206 which will unblock you here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frzifus frzifus frzifus left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide RBAC Rules for the LoadBalancerExporter's K8s Resolver
3 participants
@fyuan1316 @jaronoff97 @frzifus