Not ignore the container-names annotation when the multi-instrumentation is enabled #3213
Conversation
|
@iblancasa could we deprecate/remove |
.chloggen/feature_3090.yaml
Outdated
| component: auto-instrumentation | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: "Not ignore the container-names annotation when the multi-instrumentation is enabled" |
There was a problem hiding this comment.
Please put here the entire annotation or in the subtext. It will be clearer for end users.
I'll do it as part of other PR because I don't want this one to be really big. Just to make it easy to review. |
…ion is enabled Signed-off-by: Israel Blancas <iblancasa@gmail.com>
iblancasa
force-pushed
the
feature/3090
branch
from
1b10e4b
to
8989fc3
Compare
I'm not sure. I read the |
|
Checking the errors in the E2E tests... |
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
…or into feature/3090
…rator into feature/3090
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
…or into feature/3090
|
This PR may have broken handling of language-specific annotations. I have deployment with the following pod annotations: instrumentation.opentelemetry.io/inject-sdk: otel-system/otel-instrumentation
instrumentation.opentelemetry.io/sdk-container-names: test-appThis works fine with versions up to v0.107.0, but after upgrade to v0.108.0 it no longer injects variables. |
Description: previously, the
container-namesannotation was ignored when multi-instrumentation was enabled in the operator (even if for that Instrumentation object a single instrumentation was used). Now, it is not ignored.If that annotation is used simultaneously with the ones used for multi-instrumentation, the
areContainerNamesConfiguredForMultipleInstrumentationswill raise an error.Link to tracking Issue(s):
This is the first step to enable the multi-instrumentation by default.