Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow autoscaler targetCPUUtilization and TargetMemoryUtilization to be greater than 99 #3260

Conversation

davidhaja
Copy link
Contributor

@davidhaja davidhaja commented Sep 3, 2024

Description:
Allowing the autoscaler targetCPUUtilization and TargetMemoryUtilization to be greater than 99.
Added an extra test for checking the TargetMemoryUtilization value.

Link to tracking Issue(s):
3258

Testing:
TestOTELColValidatingWebhook tests the modified conditions

Documentation:
N/A

@davidhaja davidhaja requested a review from a team September 3, 2024 22:37
Copy link
Contributor

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@jaronoff97 jaronoff97 merged commit ba2eba6 into open-telemetry:main Sep 4, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autoscaler targetCPUUtilization and TargetMemoryUtilization cannot be greater than 99
3 participants