Fix flaky controller tests #3560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiatekm
force-pushed
the
test/fix-flaky-tests
branch
from
37ddc04 to
b1388fe
Compare
swiatekm
force-pushed
the
test/fix-flaky-tests
branch
from
b1388fe to
896825b
Compare
jaronoff97
approved these changes
Dec 19, 2024
This was referenced Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a flaky controller test. I'm still not sure why it can take so long for this test to see that the ConfigMap was deleted, but it is a fact of life. 30 seconds looks like enough from local tests.
I've also enabled logging for these tests, as it really helps debugging failures. If this is annoying to have in the general unit test output, then maybe we can run these in a separate step?