-
Notifications
You must be signed in to change notification settings - Fork 544
feat: add HTML response handling for target allocator #3652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add HTML response handling for target allocator #3652
Conversation
c9c6e2a
to
d6cb377
Compare
4fc7fa4
to
76cf475
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look ok to me.
e7ca1d8
to
b4f43e2
Compare
25d825d
to
d96300a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other than the path, i think everything looks great! thank you 🙇
f9264cd
to
8e37185
Compare
Is it ready to be merged? |
@chenlujjj there's one conflict, otherwise yes |
Signed-off-by: Charlie Le <charlie_le@apple.com>
Signed-off-by: Charlie Le <charlie_le@apple.com>
Signed-off-by: Charlie Le <charlie_le@apple.com>
Signed-off-by: Charlie Le <charlie_le@apple.com>
Signed-off-by: Charlie Le <charlie_le@apple.com>
8e37185
to
bf30b81
Compare
Signed-off-by: Charlie Le <charlie_le@apple.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with merging this PR as-is, although I'd love it if the raw html could be removed from handler functions completely. Nonetheless, thank you for your work on this feature, it must've been a huge pain.
… to use dedicated HTML templates for bad requests and not found responses Signed-off-by: Charlie Le <charlie_le@apple.com>
Description:
Adds support for HTML output in the target allocator.
Link to tracking Issue(s):
Testing:
Configured unit tests with golden files to test that HTML renders the correct response.
To start the test, run
Setup a TA
Port-forward to the TA pod.
Once port-forwarded, go to http://localhost:8080.
Screenshots:
Home
Scrape Configs
Jobs
Targets
Collector
Job
Target