Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add traceresponse propagation to Slim auto-instrumentation #147

Closed
wants to merge 5 commits into from

Conversation

cedricziel
Copy link
Contributor

Depends on #143

@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Merging #147 (3323e94) into main (4ddd6e5) will increase coverage by 0.72%.
The diff coverage is 40.54%.

❗ Current head 3323e94 differs from pull request most recent head 9a3b527. Consider uploading reports for the commit 9a3b527 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #147      +/-   ##
============================================
+ Coverage     25.03%   25.75%   +0.72%     
+ Complexity      315      296      -19     
============================================
  Files            32       32              
  Lines          1306     1219      -87     
============================================
- Hits            327      314      -13     
+ Misses          979      905      -74     
Flag Coverage Δ
7.4 73.02% <100.00%> (+0.97%) ⬆️
8.0 30.66% <40.54%> (+1.32%) ⬆️
8.1 30.66% <40.54%> (+1.23%) ⬆️
8.2 25.77% <40.54%> (+0.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rumentation/Laravel/src/LaravelInstrumentation.php 0.00% <ø> (ø)
...mentation/Symfony/src/RequestPropagationGetter.php 0.00% <ø> (ø)
...entation/Symfony/src/ResponsePropagationSetter.php 0.00% <0.00%> (ø)
...rumentation/Symfony/src/SymfonyInstrumentation.php 0.00% <0.00%> (ø)
...tion/TraceResponse/src/TraceResponsePropagator.php 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ddd6e5...9a3b527. Read the comment docs.

@stale
Copy link

stale bot commented Jun 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 18, 2023
@stale
Copy link

stale bot commented Aug 12, 2023

This issue has been automatically closed because it has not had recent activity, but it can be reopened. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants