-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set required attribute of DB_SYSTEM #181
Conversation
This change introduces a default value for db.system, to satisfy the opentelemetry specification
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #181 +/- ##
============================================
+ Coverage 32.62% 34.76% +2.14%
- Complexity 783 791 +8
============================================
Files 69 70 +1
Lines 2970 3017 +47
============================================
+ Hits 969 1049 +80
+ Misses 2001 1968 -33
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
Co-authored-by: Lars Strojny <lars@strojny.net>
Co-authored-by: Lars Strojny <lars@strojny.net>
Co-authored-by: Lars Strojny <lars@strojny.net>
Co-authored-by: Brett McBride <brett.a.mcbride@gmail.com>
Is everybody happy for me to merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brettmc sure, just a small cosmetics issue from my side
I'm good |
This change introduces a default value for db.system, to satisfy the opentelemetry specification.
It also tracks a statement <-> PDO mapping based on the object ids so we can annotate the correct attributes on statement spans.