Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont build extension from source #182

Merged
merged 1 commit into from
Jul 23, 2023

Conversation

cedricziel
Copy link
Contributor

@cedricziel cedricziel commented Jul 22, 2023

Extension was moved to subdir thus image couldnt be built

@cedricziel cedricziel requested a review from a team July 22, 2023 08:17
@codecov
Copy link

codecov bot commented Jul 22, 2023

Codecov Report

Merging #182 (090d70c) into main (8f69ac2) will not change coverage.
The diff coverage is n/a.

❗ Current head 090d70c differs from pull request most recent head c45a43b. Consider uploading reports for the commit c45a43b to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #182   +/-   ##
=========================================
  Coverage     32.62%   32.62%           
  Complexity      783      783           
=========================================
  Files            69       69           
  Lines          2970     2970           
=========================================
  Hits            969      969           
  Misses         2001     2001           
Flag Coverage Δ
7.4 46.08% <ø> (ø)
8.0 34.83% <ø> (ø)
8.1 34.87% <ø> (ø)
8.2 32.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f69ac2...c45a43b. Read the comment docs.

@brettmc brettmc merged commit 3eeafaf into open-telemetry:main Jul 23, 2023
55 checks passed
@cedricziel cedricziel deleted the build-ext-correct branch July 23, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants