Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing broken symfony build #192

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Conversation

brettmc
Copy link
Collaborator

@brettmc brettmc commented Sep 14, 2023

No description provided.

@brettmc brettmc requested a review from a team September 14, 2023 04:27
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #192 (1b82e93) into main (c8e79a8) will increase coverage by 6.12%.
The diff coverage is n/a.

❗ Current head 1b82e93 differs from pull request most recent head fd58370. Consider uploading reports for the commit fd58370 to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #192      +/-   ##
============================================
+ Coverage     28.60%   34.73%   +6.12%     
- Complexity      472      814     +342     
============================================
  Files            47       71      +24     
  Lines          1755     3078    +1323     
============================================
+ Hits            502     1069     +567     
- Misses         1253     2009     +756     
Flag Coverage Δ
7.4 46.18% <ø> (-6.12%) ⬇️
8.0 34.79% <ø> (+6.92%) ⬆️
8.1 34.82% <ø> (+6.89%) ⬆️
8.2 34.67% <ø> (+6.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8e79a8...fd58370. Read the comment docs.

@brettmc
Copy link
Collaborator Author

brettmc commented Sep 14, 2023

"fixing" might be generous, but the tests pass now.

@pdelewski pdelewski merged commit e317b41 into open-telemetry:main Sep 14, 2023
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants