Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add traces attributes #214

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

weslenteche
Copy link
Contributor

After the semantic convention was stabilized in v1.23, I added some missing attributes.
I noticed that some automatic instrumentation already had it, but other instrumentation was missing.

@weslenteche weslenteche requested a review from a team November 23, 2023 22:49
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #214 (d2abf8b) into main (f3e21f4) will decrease coverage by 0.13%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #214      +/-   ##
============================================
- Coverage     32.02%   31.90%   -0.13%     
  Complexity      878      878              
============================================
  Files            79       79              
  Lines          3360     3373      +13     
============================================
  Hits           1076     1076              
- Misses         2284     2297      +13     
Flag Coverage Δ
7.4 46.34% <ø> (ø)
8.0 31.73% <0.00%> (-0.14%) ⬇️
8.1 31.76% <0.00%> (-0.14%) ⬇️
8.2 31.85% <0.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ion/CodeIgniter/src/CodeIgniterInstrumentation.php 0.00% <0.00%> (ø)
...c/Instrumentation/Slim/src/SlimInstrumentation.php 0.00% <0.00%> (ø)
...rumentation/Symfony/src/SymfonyInstrumentation.php 0.00% <0.00%> (ø)
...Instrumentation/Psr15/src/Psr15Instrumentation.php 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3e21f4...d2abf8b. Read the comment docs.

Copy link
Collaborator

@brettmc brettmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@brettmc brettmc merged commit e34d500 into open-telemetry:main Nov 24, 2023
62 of 63 checks passed
@weslenteche weslenteche deleted the feat/add-traces-attributes branch February 22, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants