fixing running phpt tests #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trying to generate code coverage for phpt tests breaks the tests, so move them out of "integration" and into their own suite. Introduce a full non-coverage test suite run, and only generate coverage off unit and integration as we did previously.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #217 +/- ##
=============================================
+ Coverage 31.90% 85.85% +53.95%
- Complexity 878 883 +5
=============================================
Files 79 80 +1
Lines 3373 3393 +20
=============================================
+ Hits 1076 2913 +1837
+ Misses 2297 480 -1817
Flags with carried forward coverage won't be shown. Click here to find out more. see 37 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
pdelewski
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trying to generate code coverage for phpt tests breaks the tests, so move them out of "integration" and into their own suite. Introduce a full non-coverage test suite run, and only generate coverage off unit and integration as we did previously.