Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing some build errors #298

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Conversation

brettmc
Copy link
Collaborator

@brettmc brettmc commented Oct 2, 2024

No description provided.

@brettmc brettmc requested a review from a team as a code owner October 2, 2024 03:19
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.36%. Comparing base (3dd4f06) to head (3e54ba7).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...rumentation/CakePHP/src/Hooks/Cake/Http/Server.php 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #298      +/-   ##
============================================
- Coverage     82.68%   80.36%   -2.33%     
- Complexity      949     1024      +75     
============================================
  Files            89       98       +9     
  Lines          3807     4111     +304     
============================================
+ Hits           3148     3304     +156     
- Misses          659      807     +148     
Flag Coverage Δ
Aws 85.75% <ø> (ø)
Context/Swoole 0.00% <ø> (ø)
Instrumentation/CakePHP 20.00% <0.00%> (?)
Instrumentation/CodeIgniter 73.94% <ø> (ø)
Instrumentation/ExtAmqp 89.58% <ø> (ø)
Instrumentation/Guzzle 69.73% <ø> (ø)
Instrumentation/HttpAsyncClient 81.33% <ø> (ø)
Instrumentation/IO 70.90% <ø> (ø)
Instrumentation/MongoDB 77.33% <ø> (ø)
Instrumentation/OpenAIPHP 86.82% <ø> (ø)
Instrumentation/PDO 89.56% <ø> (ø)
Instrumentation/Psr14 78.12% <ø> (ø)
Instrumentation/Psr15 93.50% <ø> (ø)
Instrumentation/Psr16 97.50% <ø> (?)
Instrumentation/Psr18 82.08% <ø> (ø)
Instrumentation/Psr3 61.03% <100.00%> (?)
Instrumentation/Psr6 97.61% <ø> (?)
Instrumentation/Slim 86.95% <ø> (ø)
Instrumentation/Symfony 89.03% <ø> (ø)
Instrumentation/Yii 77.77% <ø> (ø)
Logs/Monolog 100.00% <ø> (ø)
Propagation/ServerTiming 100.00% <ø> (ø)
Propagation/TraceResponse 100.00% <ø> (ø)
ResourceDetectors/Container 93.02% <ø> (ø)
Sampler/RuleBased 32.14% <ø> (ø)
Shims/OpenTracing 92.99% <ø> (ø)
Symfony 88.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ntation/CakePHP/src/Hooks/Cake/Command/Command.php 85.29% <ø> (ø)
src/Instrumentation/Psr3/src/Formatter.php 100.00% <100.00%> (ø)
...rumentation/CakePHP/src/Hooks/Cake/Http/Server.php 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dd4f06...3e54ba7. Read the comment docs.

Copy link
Collaborator

@bobstrecansky bobstrecansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that we had a couple failures here related to PHPCS and Phan in this PR. If those are expected, feel free to merge at will.

@brettmc brettmc merged commit c06f8c6 into open-telemetry:main Oct 2, 2024
109 of 120 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants