Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KIND::CONSUMER instrumentation implemented #307

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

RichardChukwu
Copy link
Contributor

Fixes #1314
Related #304

-Added the "consume" operation with SpanKind::KIND_CONSUMER for receiving messages.

-Updated span names to use publish, send, and consume as per the spec, ensuring naming consistency for operations.

-Instrumented the SenderInterface for both sending and receiving spans, with the appropriate SpanKind (producer for sending and consumer for receiving).

@RichardChukwu RichardChukwu requested a review from a team as a code owner October 17, 2024 10:27
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.53%. Comparing base (78a04ce) to head (d9338d4).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #307      +/-   ##
============================================
- Coverage     80.33%   76.53%   -3.81%     
+ Complexity     1026      564     -462     
============================================
  Files            98       61      -37     
  Lines          4114     2267    -1847     
============================================
- Hits           3305     1735    -1570     
+ Misses          809      532     -277     
Flag Coverage Δ
Aws 85.55% <ø> (+0.03%) ⬆️
Context/Swoole ?
Instrumentation/CakePHP 20.00% <ø> (ø)
Instrumentation/CodeIgniter 73.77% <ø> (-0.18%) ⬇️
Instrumentation/ExtAmqp ?
Instrumentation/Guzzle 69.51% <ø> (-0.23%) ⬇️
Instrumentation/HttpAsyncClient 81.25% <ø> (-0.09%) ⬇️
Instrumentation/IO 70.68% <ø> (-0.22%) ⬇️
Instrumentation/MongoDB 76.31% <ø> (-1.02%) ⬇️
Instrumentation/OpenAIPHP 87.31% <ø> (+0.49%) ⬆️
Instrumentation/PDO 89.95% <ø> (+0.39%) ⬆️
Instrumentation/Psr14 77.14% <ø> (-0.99%) ⬇️
Instrumentation/Psr15 93.82% <ø> (+0.32%) ⬆️
Instrumentation/Psr16 97.56% <ø> (+0.06%) ⬆️
Instrumentation/Psr18 81.15% <ø> (-0.94%) ⬇️
Instrumentation/Psr3 ?
Instrumentation/Psr6 97.67% <ø> (+0.05%) ⬆️
Instrumentation/Slim 86.89% <ø> (-0.06%) ⬇️
Instrumentation/Symfony ?
Instrumentation/Yii 77.68% <ø> (-0.10%) ⬇️
Logs/Monolog ?
Propagation/ServerTiming 100.00% <ø> (ø)
Propagation/TraceResponse 100.00% <ø> (ø)
ResourceDetectors/Container 93.02% <ø> (ø)
Sampler/RuleBased 33.51% <ø> (+1.37%) ⬆️
Shims/OpenTracing 92.45% <ø> (-0.55%) ⬇️
Symfony ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 72 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78a04ce...d9338d4. Read the comment docs.

composer.json Outdated Show resolved Hide resolved
return new LegacyInMemoryTransport();
}

protected function getReceiver()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this different enough from getTransport to require a method? It doesn't return a receiver but a transport...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RichardChukwu have you had any time to look further into this?

Copy link
Contributor Author

@RichardChukwu RichardChukwu Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ChrisLightfootWild, thanks for asking.

Not really, I'll appreciate any assistance please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants