-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KIND::CONSUMER instrumentation implemented #307
base: main
Are you sure you want to change the base?
Conversation
…ER and KIND_CONSUMER
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #307 +/- ##
============================================
- Coverage 80.33% 76.53% -3.81%
+ Complexity 1026 564 -462
============================================
Files 98 61 -37
Lines 4114 2267 -1847
============================================
- Hits 3305 1735 -1570
+ Misses 809 532 -277 Flags with carried forward coverage won't be shown. Click here to find out more. see 72 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
return new LegacyInMemoryTransport(); | ||
} | ||
|
||
protected function getReceiver() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this different enough from getTransport
to require a method? It doesn't return a receiver but a transport...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RichardChukwu have you had any time to look further into this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ChrisLightfootWild, thanks for asking.
Not really, I'll appreciate any assistance please
Fixes #1314
Related #304
-Added the "consume" operation with SpanKind::KIND_CONSUMER for receiving messages.
-Updated span names to use publish, send, and consume as per the spec, ensuring naming consistency for operations.
-Instrumented the SenderInterface for both sending and receiving spans, with the appropriate SpanKind (producer for sending and consumer for receiving).