Fix broken Serializer when using Laravel Illuminate\Queue\LuaScripts #309
Conversation
Since introduction of RedisCommandWatcher, auto-instrumentation for Laravel fails when using Lua scripts for Queue management, since command argument array can contains arrays.
|
Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one. |
|
Looks sensible to me - can you add (or modify) a test for this? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #309 +/- ##
============================================
+ Coverage 80.33% 83.29% +2.95%
+ Complexity 1026 896 -130
============================================
Files 98 83 -15
Lines 4114 3585 -529
============================================
- Hits 3305 2986 -319
+ Misses 809 599 -210 Flags with carried forward coverage won't be shown. Click here to find out more. see 56 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
gdaszuta
force-pushed
the
laravel-queue-redis
branch
from
a1b7979 to
11c4078
Compare
|
@brettmc added a simple test for the case, is this enough? |
|
@MilesChou would you be happy with these changes? |
Since introduction of RedisCommandWatcher, auto-instrumentation for Laravel fails when using Lua scripts for Queue management, since command argument array can contains arrays.
I don't have the time right now to prepare failing PoC, problematic payload is created in Illuminate\Queue\RedisQueue, it seems that it fails when multiple jobs are passed into argument as an object.