Test builds for ARM

[bobstrecansky]

Before opening a feature request against this repo, consider whether the feature should/could be implemented in the other OpenTelemetry client libraries. If so, please open an issue in opentelemetry-specification first.

Is your feature request related to a problem?
If so, provide a concise description of the problem.
During the SIG meeting today, we discussed the potential for validating ARM builds for opentelemetry-php.

Describe the solution you'd like
What do you want to happen instead? What is the expected behavior?
We'd like to be able to build this project for ARM64

[brettmc]

It looks like we'd need to obtain a custom github runner to be able to run ARM: https://github.com/marketplace/actions/setup-php-action#multi-arch-setup
Other options:
actions/runner-images#5631 <- arm support may be coming in the future
https://github.com/uraimo/run-on-arch-action <- add an extra virtualization layer with qemu (slower)

We do have access to some machines, so maybe one of them could be spun up as a self-hosted ARM runner? (although, the docs warn about doing this for public repositories: https://docs.github.com/en/actions/hosting-your-own-runners/adding-self-hosted-runners)

[bobstrecansky]

Also planning on following up with the other language maintainers to see what their plans are for ARM support.

[brettmc]

buildjet.com is a service which claims to have ARM-based github runners, and a free trial period. We could at least test out doing ARM-based builds there. Not sure of CNCF might pay for ongoing usage?

[brettmc]

Using buildjet, I was able to validate that our current test suite is successful on an ARM-based runner: https://github.com/brettmc/opentelemetry-php/actions/runs/4288355161/jobs/7470265577

[bobstrecansky]

Nice, thank you @brettmc! I meant to circle back around to this, but glad you were able to test with buildjet. I'm following up in the maintainers channel to see about dedicated/ARM based runners.

[bobstrecansky]

open-telemetry/community#1162

[bobstrecansky]

Dropping the Required for GA tag, as this isn't probably isn't a General Availability requirement

[bobstrecansky]

I was also able to successfully stand up an arm64 instance in GCP and perform the actions in the Makefile. There was a small error in the unit tests, but I don' think it's a showstopper:

There were 4 failures:

1) OpenTelemetry\Tests\Unit\Context\DebugScopeTest::test_detached_scope_detach
Failed asserting that exception of type "PHPUnit\Framework\Error\Notice" is thrown.

phpvfscomposer:///home/bob_strecansky/opentelemetry-php/vendor/phpunit/phpunit/phpunit:97

2) OpenTelemetry\Tests\Unit\Context\DebugScopeTest::test_order_mismatch_scope_detach
Failed asserting that exception of type "PHPUnit\Framework\Error\Notice" is thrown.

phpvfscomposer:///home/bob_strecansky/opentelemetry-php/vendor/phpunit/phpunit/phpunit:97

3) OpenTelemetry\Tests\Unit\Context\DebugScopeTest::test_inactive_scope_detach
Failed asserting that exception of type "PHPUnit\Framework\Error\Notice" is thrown.

phpvfscomposer:///home/bob_strecansky/opentelemetry-php/vendor/phpunit/phpunit/phpunit:97

4) OpenTelemetry\Tests\Unit\Context\DebugScopeTest::test_missing_scope_detach
Failed asserting that exception of type "PHPUnit\Framework\Error\Notice" is thrown.

phpvfscomposer:///home/bob_strecansky/opentelemetry-php/vendor/phpunit/phpunit/phpunit:97

--

[bobstrecansky]

I am going to close this for now because I feel it's mostly alleviated. Happy to have it reopened if someone feels it needs more attention.