Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARM64 CI tests #12920

Closed
odidev opened this issue Aug 3, 2022 · 19 comments · Fixed by #32135
Closed

Add ARM64 CI tests #12920

odidev opened this issue Aug 3, 2022 · 19 comments · Fixed by #32135
Assignees
Labels
ci-cd CI, CD, testing, build issues discussion needed Community discussion needed priority:p2 Medium

Comments

@odidev
Copy link

odidev commented Aug 3, 2022

Hi Team,

I'm interested in adding arm64 support in the ci to this repository.

Is your feature request related to a problem? Please describe.
This repository doesn’t have arm64 testing support in the GitHub actions ci.

Describe the solution you'd like
I have explored the repository and CI being used, arm64 builds can be added in the GitHub actions CI to enable test for arm64.

Describe alternatives you've considered
I am working to add arm64 support in GitHub actions to add builds for testing, we can do ARM64 testing in GitHub actions using self-hosted arm64 runners.

If interested, we can get access to ARM H/W through WorksOnArm.

Additional context
Do you have any plans for adding the arm64 platform in CI? It will be very helpful if arm64 support is available.

Please share your thoughts on this.

@mx-psi
Copy link
Member

mx-psi commented Aug 3, 2022

@odidev Thanks for the request!

Note that we already ensure the Collector builds on ARM through cross-compilation, so I assume this is about unit tests? Or did you have a different use case in mind?

I have explored the repository and CI being used, arm64 builds can be added in the GitHub actions CI to enable test for arm64.

How can this be done? I tried reading actions/runner-images/issues/2552 but found it a bit confusing and I am not sure that this is natively supported by Github. Could you share a bit more about this?

Do you have any plans for adding the arm64 platform in CI? It will be very helpful if arm64 support is available.

AFAIK there are not plans for adding this. We do not have a well-defined policy on what level of testing and support we provide for different architectures, so it's hard to give a general answer that reflects general consensus.

My personal opinion is that adding this would be okay so long as

  1. we track and actively fix or skip unit tests failing on ARM
  2. this does not increase the running time of CI for PRs too much

@mx-psi mx-psi added ci-cd CI, CD, testing, build issues discussion needed Community discussion needed labels Aug 3, 2022
@TylerHelmuth TylerHelmuth added the priority:p2 Medium label Aug 5, 2022
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Nov 10, 2022
@brettmc
Copy link

brettmc commented Jan 9, 2023

We have a lowish-priority issue over in opentelemetry-php to try building/testing against arm64, and having access to an arm-based self-hosted runner seems like it would help us out.

At the moment, our options seem to be using virtualization, or waiting for github to add arm support to their runners.

@atoulme
Copy link
Contributor

atoulme commented Mar 12, 2023

I am in talks with a vendor to get an appliance to run arm tests as a github action runners. I will assign this issue to myself.

@atoulme atoulme self-assigned this Mar 12, 2023
@atoulme atoulme removed the Stale label Mar 12, 2023
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label May 11, 2023
@dneary
Copy link

dneary commented May 25, 2023

I would love to help get this to happen! How can I help? What would be useful - hardware, cloud credits, or something else? Doing native builds and tests should speed up builds.

@atoulme
Copy link
Contributor

atoulme commented May 25, 2023

I have an Ampere Mt Collins server provided for free by Ampere Computing to support this. It's sitting in my garage and I need help to set it up to use different VMs for different github action workers. Please allow me some time to get to it.

@github-actions github-actions bot removed the Stale label May 27, 2023
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Jul 26, 2023
@atoulme atoulme removed the Stale label Jul 26, 2023
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Sep 25, 2023
@dneary
Copy link

dneary commented Nov 17, 2023

I have an Ampere Mt Collins server provided for free by Ampere Computing to support this. It's sitting in my garage and I need help to set it up to use different VMs for different github action workers. Please allow me some time to get to it.

Antoine, we may have an even better option! I believe you already spoke to my colleague Peter - early next week, we should be able to confirm your participation in the actuated pilot - the full details of the pilot, and the link for "How do we get access?" is here: Announcing managed Arm CI for CNCF projects

@atoulme
Copy link
Contributor

atoulme commented Nov 17, 2023

Absolutely, I am working with Peter right now on blogging about our experience. I will read this ASAP.

@github-actions github-actions bot removed the Stale label Nov 17, 2023
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Jan 17, 2024
@mx-psi mx-psi changed the title Add ARM64 Support Add ARM64 CI tests Jan 17, 2024
@github-actions github-actions bot removed the Stale label Jan 18, 2024
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Mar 19, 2024
@mx-psi mx-psi removed the Stale label Mar 19, 2024
@mx-psi
Copy link
Member

mx-psi commented Mar 19, 2024

@atoulme Should we close this in favor or open-telemetry/opentelemetry-collector/issues/9731?

@atoulme
Copy link
Contributor

atoulme commented Mar 19, 2024

I think we can keep this issue and make it a blocker to close open-telemetry/opentelemetry-collector#9731.

Currently, we are trying to add an arm64 CI for the collector core repository with open-telemetry/opentelemetry-collector#9584, once that is merged, I can work to add the same level of CI support for contrib.

@mx-psi
Copy link
Member

mx-psi commented Mar 20, 2024

Alright, marking as 'on hold' then

@atoulme atoulme removed the on hold This is blocked by another PR/issue label Apr 2, 2024
@atoulme
Copy link
Contributor

atoulme commented Apr 2, 2024

No longer on hold.

@atoulme
Copy link
Contributor

atoulme commented Apr 3, 2024

Please see #32136

andrzej-stencel pushed a commit that referenced this issue Apr 8, 2024
**Description:**
Add an ARM build using Actuated, which will run an ARM github action
runner on CNCF allocated Equinix colocated ARM servers.

**Link to tracking Issue:**
Fixes #12920
Fixes #32136
@atoulme
Copy link
Contributor

atoulme commented Apr 8, 2024

This is now complete. Please feel free to review the logs and push for more ARM64 specific tests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd CI, CD, testing, build issues discussion needed Community discussion needed priority:p2 Medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants