Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update links to openmetrics to reference the v1.0.0 release #1456

Closed
wants to merge 1 commit into from

Conversation

dashpole
Copy link

Related to prometheus/OpenMetrics#287

The OM 2.0 effort is kicked off, and will start developing on main. This updates the links to OpenMetrics to reference the 1.0 release. The OM project has also been moved into the prometheus github org.

@dashpole dashpole requested a review from a team as a code owner December 13, 2024 21:27
Copy link

welcome bot commented Dec 13, 2024

Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one.

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.31%. Comparing base (4a021fb) to head (79cc915).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1456      +/-   ##
============================================
+ Coverage     73.26%   73.31%   +0.04%     
  Complexity     2685     2685              
============================================
  Files           387      387              
  Lines          8009     8009              
============================================
+ Hits           5868     5872       +4     
+ Misses         2141     2137       -4     
Flag Coverage Δ
8.1 72.96% <ø> (-0.03%) ⬇️
8.2 73.26% <ø> (+0.08%) ⬆️
8.3 73.21% <ø> (+0.01%) ⬆️
8.4 ?
8.5 73.16% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a021fb...79cc915. Read the comment docs.

@brettmc
Copy link
Collaborator

brettmc commented Dec 14, 2024

Hi! It looks like you've already updated the upstream proto definition in open-telemetry/opentelemetry-proto#612 so what we need to do here is regenerate the proto definition from source. When a new version is tagged containing your PR's changes, let us know via an issue or on slack and I'll regenerate.

edit: looks like 1.5.0 will be released imminently, the prep work has begun.

@dashpole dashpole closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants