Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x merge #1474

Closed
wants to merge 4 commits into from
Closed

2.x merge #1474

wants to merge 4 commits into from

Conversation

brettmc
Copy link
Collaborator

@brettmc brettmc commented Jan 9, 2025

merge main into 2.x

brettmc and others added 4 commits January 7, 2025 21:18
add the php-cs-fixer no_blank_lines_after_class_opening rule and apply to codebase
the spec has added in-development otlp file/stdout exporter. We already supported this programmatically, so
add some factories and sdk config to allow configuration from environment (only for stdout, per spec)
The event logger was a Development-status component of the logging signal. It has been
removed in favour of adding emitEvent to the logger interface,
see open-telemetry/opentelemetry-specification#4319
@brettmc brettmc requested a review from a team as a code owner January 9, 2025 23:53
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 73.22%. Comparing base (81288cd) to head (3afac34).
Report is 6 commits behind head on 2.x.

Files with missing lines Patch % Lines
src/Contrib/Otlp/StdoutLogsExporterFactory.php 0.00% 3 Missing ⚠️
src/Contrib/Otlp/StdoutMetricExporterFactory.php 0.00% 3 Missing ⚠️
src/Contrib/Otlp/StdoutSpanExporterFactory.php 0.00% 3 Missing ⚠️
src/Contrib/Otlp/_register.php 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #1474      +/-   ##
============================================
- Coverage     73.33%   73.22%   -0.11%     
- Complexity     2682     2685       +3     
============================================
  Files           387      390       +3     
  Lines          8014     8026      +12     
============================================
  Hits           5877     5877              
- Misses         2137     2149      +12     
Flag Coverage Δ
8.2 73.09% <0.00%> (-0.11%) ⬇️
8.3 73.08% <0.00%> (-0.20%) ⬇️
8.4 73.04% <0.00%> (-0.20%) ⬇️
8.5 73.14% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/API/Globals.php 100.00% <ø> (ø)
...tion/AutoInstrumentation/ConfigurationRegistry.php 100.00% <ø> (ø)
src/API/Instrumentation/CachedInstrumentation.php 100.00% <ø> (ø)
src/API/Instrumentation/Configurator.php 100.00% <ø> (ø)
src/API/Instrumentation/ContextKeys.php 100.00% <ø> (ø)
src/API/Logs/NoopEventLogger.php 0.00% <ø> (ø)
src/API/Logs/NoopEventLoggerProvider.php 0.00% <ø> (ø)
...der/Instrumentation/General/HttpConfigProvider.php 0.00% <ø> (ø)
...omponentProvider/Logs/LogRecordExporterConsole.php 0.00% <ø> (ø)
...K/ComponentProvider/Logs/LogRecordExporterOtlp.php 0.00% <ø> (ø)
... and 61 more

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81288cd...3afac34. Read the comment docs.

@brettmc
Copy link
Collaborator Author

brettmc commented Jan 10, 2025

Closing, I'll do these directly to preserve history for now.

@brettmc brettmc closed this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant