-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop string options for Temporality, InstrumentType #1493
base: 2.x
Are you sure you want to change the base?
Conversation
Temporality|string|null was allowed for temporality to avoid BC in 1.x convert Temporality to an enum
- drop string|InstrumentType, which exists in 1.x for forward-compatibility
*/ | ||
public function temporality(); | ||
public function temporality(): ?Temporality; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't sure about this, however there is a lowmemory
test that fails if null is not allowed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-nullable is correct here - test should be fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the offending test. lowmemory
= "it depends on the instrument", per spec so I set a default and confirm that's used.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #1493 +/- ##
============================================
+ Coverage 70.49% 70.52% +0.02%
+ Complexity 2792 2790 -2
============================================
Files 413 411 -2
Lines 8416 8407 -9
============================================
- Hits 5933 5929 -4
+ Misses 2483 2478 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 13 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@open-telemetry/php-approvers I think this is ready |
Remove forwards-compatible Metrics features for 2.x:
$advisory
added toDefaultAggregationProviderInterface