Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type error when using LateBindingMeter::createObservable{Instrument}() #1524

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

Nevay
Copy link
Contributor

@Nevay Nevay commented Mar 5, 2025

NoopMeter::createObservableUpDownCounter(): Argument #5 must be of type callable, array given
#0 NoopMeter->createObservableUpDownCounter('php.memory.usag...', 'By', 'The amount of p...', Array, Array)
#1 LateBindingMeter->createObservableUpDownCounter('php.memory.usag...', 'By', 'The amount of p...', _: Object(Closure))

@Nevay Nevay requested a review from a team as a code owner March 5, 2025 15:38
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.74%. Comparing base (68462e0) to head (eb647fe).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/API/Metrics/LateBindingMeter.php 33.33% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1524      +/-   ##
============================================
- Coverage     70.76%   70.74%   -0.02%     
  Complexity     2763     2763              
============================================
  Files           408      408              
  Lines          8346     8344       -2     
============================================
- Hits           5906     5903       -3     
- Misses         2440     2441       +1     
Flag Coverage Δ
8.1 70.49% <33.33%> (+<0.01%) ⬆️
8.2 70.70% <33.33%> (+0.01%) ⬆️
8.3 70.69% <33.33%> (+<0.01%) ⬆️
8.4 70.67% <33.33%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/API/Metrics/LateBindingMeter.php 33.33% <33.33%> (+11.11%) ⬆️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68462e0...eb647fe. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brettmc brettmc merged commit 08c8860 into open-telemetry:main Mar 5, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants